Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve eth_call internals #763

Merged
merged 2 commits into from
May 21, 2024
Merged

refactor: improve eth_call internals #763

merged 2 commits into from
May 21, 2024

Conversation

prestwich
Copy link
Member

Motivation

Closes #761

Solution

  • Ensure the option is propagated to the internal RpcCall future params
  • drive-by improvements
    • remove redundant inner type
    • add polling state to simplify taking ownership of data
    • remove unnecessary nesting in future creation
    • is_* functions to remove weird inline matches!

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added bug Something isn't working enhancement New feature or request debt Tech debt which needs to be addressed labels May 21, 2024
@prestwich prestwich self-assigned this May 21, 2024
@prestwich prestwich merged commit 774a898 into main May 21, 2024
24 checks passed
@prestwich prestwich deleted the prestwich/overrides-opt branch May 21, 2024 09:52
This was referenced May 24, 2024
Merged
Closed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@prestwich
refactor: improve eth_call internals (alloy-rs#763)
073353e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes left review comments

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees

@prestwich prestwich

Labels
bug Something isn't working debt Tech debt which needs to be addressed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] state changeset arg breaks compatibility with certain endpoints
3 participants
@prestwich @mattsse @DaniPopes